Code Review & Acceptance

POs are responsible for reviewing all code changes within their components. The goal is to verify that the intent of the code change matches the intent of requirements in the story.

As PO, you will be assigned the pull request after the rotating peer reviewer completes their review and approval. With this in mind, it is important to double-check Jenkins Builds and the latest standards which are discussed at PO meetings.

Checklist

  • Public Methods have Javadocs

  • Code Coverage does not decrease

  • Tile versions are updated

  • Mobile Framework is updated

  • Base image update

  • Version matched Acceptance Criteria

  • Verify changelog is correct

  • Verify vv.yaml for correctness

  • Update SRVDD Regularly (Monthly, if possible.)

See also the Acceptance Review section of the Development, Peer Review, and Acceptance Process on the CKM wiki.